Add logging of clusterfuzz version

[ParisMeuleman]

No description provided.

[ParisMeuleman]

#4200 will certainly be an issue for this too

[jonathanmetzman]

Why are we adding this?

[ParisMeuleman]

I had the following error when running
python3 butler.py py_unittest -t core -v -p "*logs*"

======================================================================
ERROR: test_upload_to_logs_with_all_arguments (tests.core.metrics.fuzzer_logs_test.FuzzerLogsTest.test_upload_to_logs_with_all_arguments)
Test a call to upload_to_logs with all arguments being passed.
----
Traceback (most recent call last):
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/tests/core/metrics/fuzzer_logs_test.py", line 56, in test_upload_to_logs_with_all_arguments
    fuzzer_logs.upload_to_logs(
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/metrics/fuzzer_logs.py", line 147, in upload_to_logs
    logs.info('Uploaded file to logs bucket.', log_path=log_path)
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/metrics/logs.py", line 593, in info
    emit(logging.INFO, message, **extras)
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/metrics/logs.py", line 544, in emit
    logger = get_logger()
             ^^^^^^^^^^^^
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/metrics/logs.py", line 491, in get_logger
    configure('root')
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/metrics/logs.py", line 460, in configure
    config.dictConfig(get_logging_config_dict(name))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/pmeuleman/clusterfuzz/src/clusterfuzz/_internal/metrics/logs.py", line 185, in get_logging_config_dict
    'handler': logging_handler[name],
               ~~~~~~~~~~~~~~~^^^^^^
KeyError: 'root'

[jonathanmetzman]

I'm not entirely sure this is needed, given a log, you can always go back and find the version of CF that started the task.

[ParisMeuleman]

I'm not entirely sure this is needed, given a log, you can always go back and find the version of CF that started the task.

You mean if you go back enough in the logs of a given task you'll find the version? I drafted this as a result of the outages the week before, I did not have a clear indication that the failure logs where from a given version, but that might just be that I did not know where to look. If we had this information we would probably have been able to pinpoint the release and take a corrective action much faster.

[jonathanmetzman]

I'm not entirely sure this is needed, given a log, you can always go back and find the version of CF that started the task.

You mean if you go back enough in the logs of a given task you'll find the version? I drafted this as a result of the outages the week before, I did not have a clear indication that the failure logs where from a given version, but that might just be that I did not know where to look. If we had this information we would probably have been able to pinpoint the release and take a corrective action much faster.

Exactly. Sorry this wasn't clear. I think I'm in favor of landing this, because it's better for something so important to be in an obvious place.