Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Mono: Version 1.023 added #4945

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Conversation

emmamarichal
Copy link
Collaborator

de122e1: [gftools-packager] Red Hat Mono: Version 1.023 added

@emmamarichal emmamarichal linked an issue Jul 15, 2022 that may be closed by this pull request
@gf-bot

This comment was marked as outdated.

@RosaWagner
Copy link
Contributor

I think the version should be consistent to avoid confusion in onbaording upgrades:

🔥 FAIL: Checking font version fields (head and name table). (com.google.fonts/check/font_version)
🔥 FAIL head version is "1.00999" while name version string (for platform 3, encoding 1) is "Version 1.023". [code: mismatch]

@RosaWagner RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward and removed - Ready for Review labels Jul 21, 2022
@gf-bot
Copy link

gf-bot commented Jul 28, 2022

Fontbakery report

Fontbakery version: 0.8.9

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 2 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght-ital', 2) [code: summary]


[21] RedHatMono-Italic[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x01CD (LATIN CAPITAL LETTER A WITH CARON)

    • 0x1E9E (LATIN CAPITAL LETTER SHARP S)

    • 0x01CE (LATIN SMALL LETTER A WITH CARON)

    • And 0x0312 (COMBINING TURNED COMMA ABOVE)
      [code: missing-codepoints]

🔥 FAIL: The variable font 'wght' (Weight) axis coordinate must be 400 on the 'Regular' instance. (com.google.fonts/check/varfont/regular_wght_coord)
  • 🔥 FAIL The "wght" axis coordinate of the "Regular" instance must be 400. Got None instead. [code: wght-not-400]
🔥 FAIL: The variable font 'wght' (Weight) axis coordinate must be 700 on the 'Bold' instance. (com.google.fonts/check/varfont/bold_wght_coord)
  • 🔥 FAIL The "wght" axis coordinate of the "Bold" instance must be 700. Got None instead. [code: wght-not-700]
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17, and its postScriptNameID value is set to 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Light Italic' instance has the same coordinates as the default instance; its subfamilyNameID should be either 2 or 17, instead of 257. [code: invalid-default-instance-subfamily-nameid:257]
  • 🔥 FAIL 'Light Italic' instance has the same coordinates as the default instance; its postScriptNameID should be 6, instead of 272. [code: invalid-default-instance-postscript-nameid:272]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure Stylistic Sets have description. (com.google.fonts/check/stylisticset_description)
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • reversequotedblleft

    • cordinal

    • CR

    • NULL

    • reversequoteleft

    • And commaaccent
      [code: unreachable-glyphs]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Does the font have a DSIG table? (com.google.fonts/check/dsig)
  • WARN This font has a digital signature (DSIG table) which is only required - even if only a placeholder - on old programs like MS Office 2013 in order to work properly.
    The current recommendation is to completely remove the DSIG table. [code: found-DSIG]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • exclam (U+0021): X=281.5,Y=0.5 (should be at baseline 0?)

    • period (U+002E): X=281.5,Y=0.5 (should be at baseline 0?)

    • colon (U+003A): X=281.5,Y=0.5 (should be at baseline 0?)

    • question (U+003F): X=257.5,Y=0.5 (should be at baseline 0?)

    • i (U+0069): X=351.0,Y=702.0 (should be at cap-height 700?)

    • j (U+006A): X=444.5,Y=702.0 (should be at cap-height 700?)

    • braceleft (U+007B): X=481.5,Y=701.5 (should be at cap-height 700?)

    • plusminus (U+00B1): X=57.0,Y=-1.0 (should be at baseline 0?)

    • plusminus (U+00B1): X=438.0,Y=-1.0 (should be at baseline 0?)

    • ae (U+00E6): X=456.0,Y=2.0 (should be at baseline 0?)

    • And 46 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/redhatmono/RedHatMono-Italic[wght].ttf
Dehinted Size 72.2kb
Hinted Size 72.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.023'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.023"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/redhatmono [code: family-path]

[19] RedHatMono[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x01CD (LATIN CAPITAL LETTER A WITH CARON)

    • 0x1E9E (LATIN CAPITAL LETTER SHARP S)

    • 0x01CE (LATIN SMALL LETTER A WITH CARON)

    • And 0x0312 (COMBINING TURNED COMMA ABOVE)
      [code: missing-codepoints]

🔥 FAIL: Ensure component transforms do not perform scaling or rotation. (com.google.fonts/check/transformed_components)
  • 🔥 FAIL The following glyphs had components with scaling or rotation
    or inverted outline direction:

  • reversequoteleft (component comma)

  • reversequotedblleft (component comma)

  • reversequotedblleft (component comma)
    [code: transformed-components]

🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17, and its postScriptNameID value is set to 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Light' instance has the same coordinates as the default instance; its subfamilyNameID should be either 2 or 17, instead of 257. [code: invalid-default-instance-subfamily-nameid:257]
  • 🔥 FAIL 'Light' instance has the same coordinates as the default instance; its postScriptNameID should be 6, instead of 269. [code: invalid-default-instance-postscript-nameid:269]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure Stylistic Sets have description. (com.google.fonts/check/stylisticset_description)
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • reversequotedblleft

    • cordinal

    • CR

    • NULL

    • And reversequoteleft
      [code: unreachable-glyphs]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Does the font have a DSIG table? (com.google.fonts/check/dsig)
  • WARN This font has a digital signature (DSIG table) which is only required - even if only a placeholder - on old programs like MS Office 2013 in order to work properly.
    The current recommendation is to completely remove the DSIG table. [code: found-DSIG]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • six (U+0036): X=445.0,Y=701.0 (should be at cap-height 700?)

    • nine (U+0039): X=155.0,Y=-1.0 (should be at baseline 0?)

    • section (U+00A7): X=383.0,Y=699.5 (should be at cap-height 700?)

    • plusminus (U+00B1): X=110.0,Y=-1.0 (should be at baseline 0?)

    • plusminus (U+00B1): X=490.0,Y=-1.0 (should be at baseline 0?)

    • Oslash (U+00D8): X=520.0,Y=701.0 (should be at cap-height 700?)

    • Oslash (U+00D8): X=576.0,Y=701.0 (should be at cap-height 700?)

    • eth (U+00F0): X=232.0,Y=699.0 (should be at cap-height 700?)

    • ccaron (U+010D): X=162.0,Y=698.0 (should be at cap-height 700?)

    • ccaron (U+010D): X=206.0,Y=698.0 (should be at cap-height 700?)

    • And 30 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/redhatmono/RedHatMono[wght].ttf
Dehinted Size 66.5kb
Hinted Size 66.5kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.023'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.023"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/redhatmono [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 15 102 19 312 0
0% 2% 3% 22% 4% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

The font is already onboarded like that so that's fine, but it would be good to report them this fail so they fix it in the next upgrade:

🔥 FAIL: Ensure component transforms do not perform scaling or rotation. ([com.google.fonts/check/transformed_components](https://font-bakery.readthedocs.io/en/stable/fontbakery/profiles/universal.html#com.google.fonts/check/transformed_components))
🔥 FAIL The following glyphs had components with scaling or rotation
or inverted outline direction:

reversequoteleft (component comma)

reversequotedblleft (component comma)

reversequotedblleft (component comma)
[code: transformed-components]

They can add the decompose transformed components filter to the fontmake command in their build script; --filter DecomposeTransformedComponentsFilter

@RosaWagner RosaWagner added - Ready for Review and removed -- Needs Upstream Resolution Upstream fix required before moving forward - Ready for Review labels Jul 28, 2022
@RosaWagner RosaWagner merged commit 2dff15c into main Jul 28, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_redhatmono branch July 28, 2022 15:25
@vv-monsalve vv-monsalve added --- Live Font is visible on API and removed --- to production labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I Small Fix bugs fixed but nothing added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Red Hat Display, Text, Mono
4 participants