Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solitreo: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #5293

Closed
wants to merge 1 commit into from

Conversation

RosaWagner
Copy link
Contributor

132ed38: [gftools-packager] Solitreo: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

@RosaWagner RosaWagner linked an issue Sep 22, 2022 that may be closed by this pull request
9 tasks
@gf-bot
Copy link

gf-bot commented Sep 22, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[19] Solitreo-Regular.ttf
WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • uni05D1 + uni05F3

    • uni05F3 + quoteright

    • quoteright + quotesingle

    • uni05D2 + uni05F3

    • uni05F3 + uni05D5

    • uni05D5 + uni05F3

    • uni05F3 + uni05D9

    • uni05D9 + quoteright

    • quoteright + uni05D5

    • uni05D5 + quoteright

    • And 34 more.

Use -F or --full-lists to disable shortening of long lists. [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Nathan Gross is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Bryan Kirschen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • brevecombcy

    • eight.dnom

    • eight.numr

    • five.dnom

    • five.numr

    • four.dnom

    • four.numr

    • nine.dnom

    • nine.numr

    • one.dnom

    • And 13 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: percent	Contours detected: 4	Expected: 5

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: q	Contours detected: 1	Expected: 2

- Glyph name: uni2076	Contours detected: 1	Expected: 2

- Glyph name: uni2086	Contours detected: 1	Expected: 2

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: percent	Contours detected: 4	Expected: 5 

- And Glyph name: q	Contours detected: 1	Expected: 2

[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/solitreo/Solitreo-Regular.ttf
Dehinted Size 60.6kb
Hinted Size 88.1kb
Increase 27.6kb
Change 45.5 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/solitreo [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 11 55 9 152 0
0% 0% 5% 24% 4% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@eliheuer
Copy link
Collaborator

eliheuer commented Sep 22, 2022

I would prefer if I made the PR so I can get credit for the work and learn how to use the packager. Will try to make a PR with the packager today, but if there are no issues I guess it is fine to merge this. Thanks!

@RosaWagner RosaWagner added -- Needs confirmation from upstream or onboarder and removed - Ready for Review labels Sep 22, 2022
…b) added

* Solitreo Version 1.000; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/ladinoprojects/solitreo at commit ladinoprojects/solitreo@fd2871e.
@eliheuer
Copy link
Collaborator

Updated

Solitreo: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added


8db61c5: [gftools-packager] Solitreo: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

@eliheuer eliheuer force-pushed the gftools_packager_ofl_solitreo branch from 132ed38 to 8db61c5 Compare September 23, 2022 02:55
@eliheuer
Copy link
Collaborator

eliheuer commented Sep 23, 2022

I was able to get the packager to work, but it updated this PR instead of making a new one. So I am closing this, and hopefully the packager will make a new PR next time I run it.

EDIT: It worked! I opened a new PR here: #5297

Thanks for your help!

@eliheuer eliheuer closed this Sep 23, 2022
@gf-bot
Copy link

gf-bot commented Sep 23, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[19] Solitreo-Regular.ttf
WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • uni05D1 + uni05F3

    • uni05F3 + quoteright

    • quoteright + quotesingle

    • uni05D2 + uni05F3

    • uni05F3 + uni05D5

    • uni05D5 + uni05F3

    • uni05F3 + uni05D9

    • uni05D9 + quoteright

    • quoteright + uni05D5

    • uni05D5 + quoteright

    • And 34 more.

Use -F or --full-lists to disable shortening of long lists. [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Nathan Gross is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Bryan Kirschen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • brevecombcy

    • eight.dnom

    • eight.numr

    • five.dnom

    • five.numr

    • four.dnom

    • four.numr

    • nine.dnom

    • nine.numr

    • one.dnom

    • And 13 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: percent	Contours detected: 4	Expected: 5

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: q	Contours detected: 1	Expected: 2

- Glyph name: uni2076	Contours detected: 1	Expected: 2

- Glyph name: uni2086	Contours detected: 1	Expected: 2

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: percent	Contours detected: 4	Expected: 5 

- And Glyph name: q	Contours detected: 1	Expected: 2

[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/solitreo/Solitreo-Regular.ttf
Dehinted Size 60.6kb
Hinted Size 88.1kb
Increase 27.6kb
Change 45.5 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/solitreo [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 11 55 9 152 0
0% 0% 5% 24% 4% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner removed the -- Needs confirmation from upstream or onboarder label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Solitreo
3 participants