Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Martel: Version 1.002 added #8989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

emmamarichal
Copy link
Collaborator

Taken from the upstream repo https://github.com/SorkinType/Martel at commit SorkinType/Martel@3ac0dc1.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@emmamarichal emmamarichal added I Font Upgrade III VF Replacement Replace an existing family of static fonts with variable fonts II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts labels Jan 23, 2025
@emmamarichal emmamarichal linked an issue Jan 23, 2025 that may be closed by this pull request
@emmamarichal emmamarichal requested a review from m4rc1e January 23, 2025 13:12
Copy link

FontBakery report

fontbakery version: 0.13.1

Check results

[20] Martel[wght].ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. googlefonts/metadata/consistent_repo_urls

But: HTML description has 'github.com/typeoff/martel'

[code: mismatch]
🔥 FAIL Check license file has good copyright string. googlefonts/license/OFL_copyright
  • 🔥 FAIL

    First line in license file is:

"copyright (c) 2015 dan reynolds. copyright (c) 2010-2015, sorkin type co (www.sorkintype.com) with reserved font name 'merriweather'"

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)"

[code: bad-format]
⚠️ WARN Each font in set of sibling families must have the same set of vertical metrics values. superfamily/vertical_metrics
  • ⚠️ WARN

    sTypoAscender is not the same across the super-family:
    Martel Medium: 1125
    Martel Sans ExtraBold: 1150
    Martel Sans: 1150
    Martel Sans Black: 1150
    Martel Sans SemiBold: 1150
    Martel Sans Light: 1150
    Martel Sans ExtraLight: 1150
    Martel Sans Bold: 1150


    [code: superfamily-vertical-metrics]

  • ⚠️ WARN

    sTypoDescender is not the same across the super-family:
    Martel Medium: -562
    Martel Sans ExtraBold: -674
    Martel Sans: -674
    Martel Sans Black: -674
    Martel Sans SemiBold: -674
    Martel Sans Light: -674
    Martel Sans ExtraLight: -674
    Martel Sans Bold: -674


    [code: superfamily-vertical-metrics]

  • ⚠️ WARN

    usWinAscent is not the same across the super-family:
    Martel Medium: 1230
    Martel Sans ExtraBold: 1150
    Martel Sans: 1150
    Martel Sans Black: 1150
    Martel Sans SemiBold: 1150
    Martel Sans Light: 1150
    Martel Sans ExtraLight: 1150
    Martel Sans Bold: 1150


    [code: superfamily-vertical-metrics]

  • ⚠️ WARN

    usWinDescent is not the same across the super-family:
    Martel Medium: 571
    Martel Sans ExtraBold: 674
    Martel Sans: 674
    Martel Sans Black: 674
    Martel Sans SemiBold: 674
    Martel Sans Light: 674
    Martel Sans ExtraLight: 674
    Martel Sans Bold: 674


    [code: superfamily-vertical-metrics]

  • ⚠️ WARN

    ascent is not the same across the super-family:
    Martel Medium: 1125
    Martel Sans ExtraBold: 1150
    Martel Sans: 1150
    Martel Sans Black: 1150
    Martel Sans SemiBold: 1150
    Martel Sans Light: 1150
    Martel Sans ExtraLight: 1150
    Martel Sans Bold: 1150


    [code: superfamily-vertical-metrics]

  • ⚠️ WARN

    descent is not the same across the super-family:
    Martel Medium: -562
    Martel Sans ExtraBold: -674
    Martel Sans: -674
    Martel Sans Black: -674
    Martel Sans SemiBold: -674
    Martel Sans Light: -674
    Martel Sans ExtraLight: -674
    Martel Sans Bold: -674


    [code: superfamily-vertical-metrics]

⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 606 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 620: plusminus, plus

Width = 647: greater, less

Width = 602: logicalnot

Width = 625: divide

Width = 626: approxequal

Width = 646: greaterequal, lessequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- DC1

- DC2

- DC3

- DC4

- DLE

- HT

- LF

- NULL

- RS

- US

- 20 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Family metadata at ofl/martel does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+007F : try adding symbols
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, math, cherokee
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: duployan, canadian-aboriginal, old-permic, tai-le, math, tifinagh, coptic, malayalam, syriac, todhri, hebrew
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee 35 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: devanagari, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ nb_Latn (Norwegian Bokmål)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̓ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ị̓ i̦̓ i̧̓ j̓ j̣̓ j̦̓ j̧̓ j̨̓ į̆ į̇ į̈ į̊ į̋ į̒ į̓ į̣̀ į̣́ į̣̂ į̣̃ į̣̄

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Nateni (Latn, 100,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Mundani (Latn, 34,000 speakers), Southern Kisi (Latn, 360,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Lugbara (Latn, 2,200,000 speakers), Ebira (Latn, 2,200,000 speakers), Kaska (Latn, 125 speakers), Ikwere (Latn, 717,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mango (Latn, 77,000 speakers), Igbo (Latn, 27,823,640 speakers), Longto (Latn, 5,000 speakers), Southern Tutchone (Latn, 65 speakers), Zapotec (Latn, 490,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Mfumte (Latn, 79,000 speakers), Yala (Latn, 200,000 speakers), Dii (Latn, 71,000 speakers), Northern Tutchone (Latn, 85 speakers), Bafut (Latn, 158,146 speakers), Ekpeye (Latn, 226,000 speakers), Cicipu (Latn, 44,000 speakers), Navajo (Latn, 166,319 speakers), Ejagham (Latn, 120,000 speakers), Keliko (Latn, 63,000 speakers), Western Krahn (Latn, 97,800 speakers), Vute (Latn, 21,000 speakers), Gulay (Latn, 250,478 speakers), Ma’di (Latn, 584,000 speakers), Han (Latn, 6 speakers), Avokaya (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Abua (Latn, 25,000 speakers), Koonzime (Latn, 40,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Heiltsuk (Latn, 300 speakers), Makaa (Latn, 221,000 speakers), Basaa (Latn, 332,940 speakers), Dan (Latn, 1,099,244 speakers), Nzakara (Latn, 50,000 speakers), Sar (Latn, 500,000 speakers), Aghem (Latn, 38,843 speakers), Bete-Bendi (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), South Central Banda (Latn, 244,000 speakers).

[code: soft-dotted]
⚠️ WARN Checking OS/2 achVendID. googlefonts/vendor_id
  • ⚠️ WARN

    OS/2 VendorID value 'toff' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/martel


    [code: family-path]

  • ℹ️ INFO

    ofl/martelsans


    [code: family-path]

ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com fontdata_namecheck
  • ℹ️ INFO

    The family name "Martel" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/martel/Martel[wght].ttf
Dehinted Size 261.9kb
Hinted Size 262.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? googlefonts/description/git_url
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file googlefonts/description/has_article
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ℹ️ INFO

    Latn, Deva


    [code: dlng-tag]

  • ℹ️ INFO

    Latn, Deva


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 8 34 11 181 0
0% 0% 1% 3% 14% 5% 77% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 24, 2025

Devanagari mark positioning seems worse. Same situation for the Latin as well.

mt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II Indic / Brahmic / Thai / Tai Indic and non-latin South and East Asia scripts III VF Replacement Replace an existing family of static fonts with variable fonts
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Martel Dieresis
2 participants