Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement openmp threads #149

Closed
wants to merge 1 commit into from
Closed

Implement openmp threads #149

wants to merge 1 commit into from

Conversation

liyinhgqw
Copy link

Issue: #148

@bjacob
Copy link
Contributor

bjacob commented Aug 13, 2018

Thanks for the interesting pull request. We are not currently using OpenMP, and so our interest in taking in a change that makes source code even moderately more complex to improve support with OpenMP, is low. I also do not have much time at the moment to get deep enough into this to really make a good review for this PR. For now, my best course of action is to close this PR, since I don't have a short-term plan to merge it, but its code will be useful to keep around for reference, should the topic of OpenMP support arise again. Meanwhile, if you keep a GitHub fork of gemmlowp with this code patched in, users who care about OpenMP support will be able to use it, and we can then reconsider if such a fork becomes popular.

@bjacob bjacob closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants