Show Toast when offline in Download #2990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandwana001
force-pushed
the
anandwana001/662/connectivity-check-download
branch
from
0867b76 to
4390a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2990 +/- ##
============================================
- Coverage 63.55% 63.49% -0.07%
- Complexity 1242 1243 +1
============================================
Files 267 267
Lines 6506 6519 +13
Branches 911 915 +4
============================================
+ Hits 4135 4139 +4
- Misses 1785 1793 +8
- Partials 586 587 +1
|
in second pr, for complete testing. |
shobhitagarwal1612
requested changes
Jan 10, 2025
Comment on lines
+84
to
+85
| private val _showPopupEvent = MutableSharedFlow<Boolean>() | ||
| val showPopupEvent = _showPopupEvent.asSharedFlow() |
There was a problem hiding this comment.
Can we rename this to networkUnavailableEvent? Also, we aren't using the value of the emitted value. So the type can be changed to Nil.
Comment on lines
+88
to
+89
| val isConnected = networkManager.isNetworkConnected() | ||
| if (!isConnected) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #662
This is a part 1 PR where we are showing a popup if device is not connected while trying to download the offline imagery.
Part 2 will be
The part 2 will close other tickets as well where we need to build download cancel feature,
@shobhitagarwal1612 PTAL?