Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DataCollectionViewModel #2996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Jan 10, 2025

This PR is a pure refactor which is split from #2986 so that main logic change can be separated from refactors.

Things done:

  • Instead of using currentTaskId.value as default task id in all method, pass the id from the callers
  • Prevent re-creating task sequence for each value when storing values to local db.
  • Cleanup unused code.

@anandwana001 PTAL?

@auto-assign auto-assign bot requested a review from scolsen January 10, 2025 12:12
@shobhitagarwal1612 shobhitagarwal1612 requested review from anandwana001 and removed request for scolsen January 10, 2025 12:12
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.51%. Comparing base (4a5d796) to head (3a499bf).

Files with missing lines Patch % Lines
...round/ui/datacollection/DataCollectionViewModel.kt 64.51% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2996      +/-   ##
============================================
+ Coverage     63.49%   63.51%   +0.01%     
+ Complexity     1241     1238       -3     
============================================
  Files           267      267              
  Lines          6509     6504       -5     
  Branches        911      910       -1     
============================================
- Hits           4133     4131       -2     
+ Misses         1790     1788       -2     
+ Partials        586      585       -1     
Files with missing lines Coverage Δ
...round/ui/datacollection/DataCollectionViewModel.kt 80.82% <64.51%> (+1.53%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant