Use string concatenation instead of String.format.
#7644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Wow, that's really significant for such a small change. Well done to whoever caught it! 👏 |
|
Thanks, I also had a bit of a "Why did I not profile this a decade ago?" reaction :) But I suppose that plenty of us have had the opportunity, and finally I did it! |
This appears to cut ~10% off the runtime of our internal suite for `common.collect`. RELNOTES=n/a PiperOrigin-RevId: 722792128
copybara-service
bot
force-pushed
the
test_722774852
branch
from
c3be642 to
f5fa4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use string concatenation instead of
String.format.This appears to cut ~10% off the runtime of our internal suite for
common.collect.RELNOTES=n/a