Also deploy mozc_tip64.dll.pdb
#1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the biggest challenge while investigating google#1076 is that it has been reliably reproducible only on certain users' environments. One idea to accelerate the debugging in such a scenario is to ship debug symbol file for Mozc TIP DLL (e.g. mozc_tip64.dll) to users. Then we can ask the reporter to use tools like Process Explorer and Process Hacker to dump the call stack of the thread that got stuck. With this commit we actually start deploying mozc_tip64.dll.pdb to users. The storage impact looks to be acceptable overall as long as we strip private symbols [1]. Here are actual values taken in my local environment. * Mozc64.msi: + 584 kB * mozc_tip64.dll.pdb: + 6,116 kB Note that this commit does not fully take care of Bazel build. While the symbol file is actually deployed, there remain the following known issues only in Bazel build. * private symbols are not yet stripped out. * the symbol file name embedded in mozc_tip64.dll is mozc_tip.pdb rather than mozc_tip64.dll.pdb. [1]: https://learn.microsoft.com/en-us/windows-hardware/drivers/debugger/public-and-private-symbols
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1081.
Context
One of the biggest challenge while investigating the following issue has been that it is reliably reproducible only on certain users' environments.
One idea to accelerate the debugging is to ship debug symbol file for Mozc TIP DLL (e.g.
mozc_tip64.dll) to users. Then we can ask the reporter to use tools like Process Explorer and Process Hacker to dump the call stack of the thread that got stuck.Description
With this commit we actually start deploying
mozc_tip64.dll.pdbto users.The storage impact looks to be acceptable overall as long as we strip private symbols. Here are actual values taken in my local environment.
Mozc64.msi: + 584 kBmozc_tip64.dll.pdb: + 6,116 kBCaveats
This commit does not fully take care of Bazel build. While the symbol file is actually deployed, there remain the following known
issues only in Bazel build.
mozc_tip64.dllismozc_tip.pdbrather thanmozc_tip64.dll.pdb.Issue IDs
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
%ProgramFiles(x86)%\Mozc\mozc_tip64.dllwithpeview.exeincluded in Process Hacker.Here is the expected behavior.
