feat(annotation) Add default annontation properties #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add line length property
chrisj
force-pushed
the
cj-annotation-default-properties
branch
from
c826934 to
47f8d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add line length property
This came up during a meeting that the scale bar has been used as a rough measure of the size of features in datasets. I was thinking we should have a better way to measure distance and the line annotation is already a tool that has most of the requirements.
I think it would also make sense to add additional properties for other types such as ellipsoid volume and semi axis lengths, bounding box volume and dimensions.
I am currently making assumptions to cast float32array to a vec3 and there might be a better method of using the globalCoordinateSpace.