Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use forked xml package for writing #1223

Merged
merged 5 commits into from
Sep 5, 2024
Merged

refactor: use forked xml package for writing #1223

merged 5 commits into from
Sep 5, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Sep 4, 2024

#1184

We would like to modify Go's implementation on self-closing tags and this PR is the first step:

  • add encoding/xml to internal/thirdparty (also ignore this directory for lint)
  • make Maven manifest writing to use the internal version of xml
  • modify xml to not escape char data so we can call xml.EncodeToken()

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 82.77946% with 399 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (9dc3afa) to head (0c6554d).

Files with missing lines Patch % Lines
internal/thirdparty/xml/marshal.go 77.57% 108 Missing and 51 partials ⚠️
internal/thirdparty/xml/xml.go 87.45% 82 Missing and 33 partials ⚠️
internal/thirdparty/xml/read.go 80.13% 66 Missing and 23 partials ⚠️
internal/thirdparty/xml/typeinfo.go 89.71% 17 Missing and 5 partials ⚠️
internal/resolution/manifest/maven.go 51.72% 4 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   65.22%   67.65%   +2.43%     
==========================================
  Files         170      174       +4     
  Lines       14434    16719    +2285     
==========================================
+ Hits         9415    11312    +1897     
- Misses       4501     4776     +275     
- Partials      518      631     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as ready for review September 4, 2024 07:39
@cuixq cuixq requested review from michaelkedar and oliverchang and removed request for michaelkedar September 4, 2024 07:39
internal/thirdparty/xml/xml.go Show resolved Hide resolved
@cuixq cuixq merged commit 0bcec56 into google:main Sep 5, 2024
13 checks passed
@cuixq cuixq deleted the xml branch September 5, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants