Skip to content

Commit

Permalink
dashboard/app/coverage_batch.go: don't retry even on spot
Browse files Browse the repository at this point in the history
When running on Spot VMs, our batch jobs can get preempted and restarted.
For some reason, GCP sometimes starts multiple instances of the same job,
which results in duplicate results in the DB.
Prevent this by dropping MaxRetryCount. Even if a job fails for a specific day,
the data for that day will be processed on the following day, so it does not get lost.
If needed, we can manually trigger recalc using /cron/batch_coverage.
  • Loading branch information
tarasmadan committed Jul 26, 2024
1 parent 389c3e9 commit 7e805b6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion dashboard/app/coverage_batch.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ func createScriptJob(ctx context.Context, projectID, serviceAccount, script stri
MaxRunDuration: &durationpb.Duration{
Seconds: batchTimeoutSeconds,
},
MaxRetryCount: 2,
},
},
}
Expand Down

0 comments on commit 7e805b6

Please sign in to comment.