Update weather-mv's start_time, end_time parameters to string. #316

deepgabani8 · 2023-04-13T09:32:23Z

No description provided.

alxmrs

A nit to try to make the code simpler. Otherwise, this LGTM.

I have a slight hesitation that this will break some pipelines, though I realize it will make weather-mv compatible with others, still.

alxmrs · 2023-04-13T15:26:45Z

weather_mv/loader_pipeline/ee.py

@@ -182,15 +182,15 @@ class AssetData:
        name: The EE-safe name of the asset.
        target_path: The location of the asset in GCS.
        channel_names: A list of channel names in the asset.
-        start_time: Image start time in floating point seconds since epoch.
-        end_time: Image end time in floating point seconds since epoch.
+        start_time: Image start time in '%Y-%m-%dT%H:%M:%SZ' format.


Is this the same as isoformat? If it is, let's just call it that.

alxmrs · 2023-04-13T15:26:57Z

weather_mv/loader_pipeline/sinks.py

    """Turn a numpy datetime64 into UTC timestring."""
-    timestamp = float((np_time - np.datetime64(0, 's')) / np.timedelta64(1, 's'))
+    if isinstance(time, datetime.datetime):
+        return time.strftime('%Y-%m-%dT%H:%M:%SZ')


If this is isofromat, let's use time.isoformat()

Same with the line below.

Updated asset data"s start_time, end_time param to string.

279844a

alxmrs reviewed Apr 13, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update weather-mv's start_time, end_time parameters to string. #316

Update weather-mv's start_time, end_time parameters to string. #316

deepgabani8 commented Apr 13, 2023

alxmrs left a comment

alxmrs Apr 13, 2023

alxmrs Apr 13, 2023

alxmrs Apr 13, 2023

Update weather-mv's start_time, end_time parameters to string. #316

Are you sure you want to change the base?

Update weather-mv's start_time, end_time parameters to string. #316

Conversation

deepgabani8 commented Apr 13, 2023

alxmrs left a comment

Choose a reason for hiding this comment

alxmrs Apr 13, 2023

Choose a reason for hiding this comment

alxmrs Apr 13, 2023

Choose a reason for hiding this comment

alxmrs Apr 13, 2023

Choose a reason for hiding this comment