Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jongwooo
Copy link

@jongwooo jongwooo commented Apr 22, 2023

Description

Resolve #320

Update .github/workflows/ci.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=dir::$(pip cache dir)"

TO-BE

echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT

@alxmrs
Copy link
Collaborator

alxmrs commented Jul 21, 2023

This looks pretty good to me. Can you make sure that the 3.8 CI passes before me merge this?

@jongwooo jongwooo force-pushed the chore/replace-deprecated-command-with-environment-file branch from f29587e to 41eac31 Compare July 21, 2023 04:12
@jongwooo
Copy link
Author

jongwooo commented Jul 21, 2023

@alxmrs I've tried force-push. If that fails, I'll change this PR to draft and try to fix it😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants