Spanify woff2_dec #178
Open
Spanify woff2_dec #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the required C++ version to C++20, in order to use std::span.
This fuzzer takes input, compresses it, decompressed, and compresses it again, and checks that the two compressed versions are equal. This is a simple correctness fuzzer. Note that we can't just compare the decompressed version to the original input because decompression might produce a slightly different TTF file to the input, even though they are functionally the exact same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses std::span for all the raw pointers that can reasonably be rewritten (found with -Wunsafe-buffer-usage). When built with libc++ hardening this will crash on all out-of-bounds accesses instead of causing undefined behavior. This is mostly only done for woff2 decompression.
This bumps the required C++ version from 11 to 20 to get std::span, but alternatively I could pull in a span implementation from somewhere else (e.g. Chromium).
This also adds a simple correctness "fuzzer" which takes input and then compresses/decompresses/re-compresses it, and checks the two compressed versions are equivalent.