Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woff2 decoding crashes on alignment critical architectures #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MartinHusemann
Copy link

Use memcpy() instead of dereferencing casted pointers where thecast increases alignment requirements and causes crashes on some architectures.

cast increases alignment requirements and causes crashes
on some architectures.
@jbeich
Copy link

jbeich commented Mar 9, 2017

@rsheeter, can you take a look since you've added ea4c87a? The issue blocks Firefox on sparc64 (Linux, NetBSD) from working.

@rsheeter
Copy link
Contributor

Hm. In poking through I believe this was done [not by me] during perf tuning. I need to ask around internally a bit.

@MartinHusemann
Copy link
Author

Thanks for checking!
I would be slightly surprised if it would create different object code with any modern compiler on architectures where the alignment does not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants