Show group label even if a dag group is treated as loop #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_707731810
branch
12 times, most recently
from
0b86e42 to
a2d3b46
Compare
### Why It'd be great to show a custom group label even when the `treatAsLoop` of a DagGroup is set as `true` to show a different name for iterations other than `N iterations` for an iterated group. ### Testing * Screenshot: https://screenshot.googleplex.com/8kYMHodQyzXPWaj PiperOrigin-RevId: 708895829
copybara-service
bot
force-pushed
the
test_707731810
branch
from
a2d3b46 to
82aa827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show group label even if a dag group is treated as loop
Why
It'd be great to show a custom group label even when the
treatAsLoopof a DagGroup is set astrueto show a different name for iterations other thanN iterationsfor an iterated group.Testing