Skip to content

Commit

Permalink
[XLS] Enable internal FIFO materialization for several examples
Browse files Browse the repository at this point in the history
We currently require an external FIFO definition by default, and these targets only passed due to not requiring a definition for depth-0 FIFOs before commit 4b262b0

We're planning to land a more batteries-included solution soon.

PiperOrigin-RevId: 711868494
  • Loading branch information
ericastor authored and copybara-github committed Jan 3, 2025
1 parent 5b55c5d commit 9dfd0b4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions xls/examples/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,7 @@ xls_ir_verilog(
"streaming_channel_ready_suffix": "_ready",
"streaming_channel_valid_suffix": "_valid",
"use_system_verilog": "true",
"materialize_internal_fifos": "true",
},
verilog_file = "delay.sv",
)
Expand Down
3 changes: 3 additions & 0 deletions xls/modules/zstd/memory/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ mem_reader_codegen_args = common_codegen_args | {
"flop_inputs_kind": "skid",
"flop_outputs_kind": "skid",
"clock_period_ps": MEM_READER_CLOCK_PERIOD_PS,
"materialize_internal_fifos": "true",
}

xls_dslx_verilog(
Expand Down Expand Up @@ -440,6 +441,7 @@ mem_reader_adv_codegen_args = common_codegen_args | {
"flop_inputs_kind": "skid",
"flop_outputs_kind": "skid",
"clock_period_ps": MEM_READER_CLOCK_PERIOD_PS,
"materialize_internal_fifos": "true",
}

xls_dslx_verilog(
Expand Down Expand Up @@ -668,6 +670,7 @@ mem_writer_codegen_args = common_codegen_args | {
"flop_inputs_kind": "skid",
"flop_outputs_kind": "skid",
"worst_case_throughput": "1",
"materialize_internal_fifos": "true",
}

xls_dslx_verilog(
Expand Down

0 comments on commit 9dfd0b4

Please sign in to comment.