[write] Use Vec instead of BTreeSet for name records #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an invariant that entries in the name_records array are sorted, and to enforce this at the type level the initial design used a BTreeSet for these records. This didn't fully help, though, because it was still possible to have a duplicate entry in the array (the same platform/encoding/language/nameId, mapped to different strings) since the string itself is included in the Eq method of `NameRecord`. This patch tries to be less cute: it is now the responsibility of the caller to make sure that their data is right, and we will verify this at validation time. Ultimately this probably deserves a builder (there's one in fea-rs that should maybe get moved over here?)
I appreciate this being a problem but ... wouldn't using a map model this better? - (plat/enc/lang/nameid) => value |
rsheeter
approved these changes
Nov 20, 2024
|
This is in generated code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an invariant that entries in the name_records array are sorted, and to enforce this at the type level the initial design used a BTreeSet for these records.
This didn't fully help, though, because it was still possible to have a duplicate entry in the array (the same
platform/encoding/language/nameId, mapped to different strings) since the string itself is included in the Eq method of
NameRecord.This patch tries to be less cute: it is now the responsibility of the caller to make sure that their data is right, and we will verify this at validation time.
Ultimately this probably deserves a builder (there's one in fea-rs that should maybe get moved over here?)
cc @simoncozens; I recall you not enjoying the ergonomics of the
BTreeSetapproach, so here you go 💁