Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[collections] Add a RangeSet collection. #1266

Merged
merged 6 commits into from
Nov 28, 2024
Merged

[collections] Add a RangeSet collection. #1266

merged 6 commits into from
Nov 28, 2024

Conversation

garretrieger
Copy link
Contributor

This stores a disjoint list of ranges with automatica merging of overlapping and adjacent ranges.

@garretrieger garretrieger requested a review from cmyr November 27, 2024 22:35
cmyr
cmyr approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes inline.

  • should we consider whether or not there is an ecosystem crate that suits our needs?

read-fonts/src/collections/range_set/mod.rs Outdated Show resolved Hide resolved
read-fonts/src/collections/range_set/mod.rs Outdated Show resolved Hide resolved
read-fonts/src/collections/range_set/mod.rs Outdated Show resolved Hide resolved
read-fonts/src/collections/range_set/mod.rs Outdated Show resolved Hide resolved
read-fonts/src/collections.rs Outdated Show resolved Hide resolved
cmyr
cmyr approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some notes inline

read-fonts/src/collections/range_set.rs Outdated Show resolved Hide resolved
read-fonts/src/collections/range_set.rs Outdated Show resolved Hide resolved
read-fonts/src/collections/range_set.rs Show resolved Hide resolved
@garretrieger garretrieger merged commit ab49fe6 into main Nov 28, 2024
10 checks passed
@garretrieger garretrieger deleted the range_set branch November 28, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garretrieger @cmyr