Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IFT] track design space intersection size in IntersectionInfo. #1268

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

garretrieger
Copy link
Contributor

No description provided.

@garretrieger garretrieger requested a review from cmyr November 28, 2024 22:11
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

I'm curious if you're enforcing the invariant that start <= end, for your ranges? And/or have some test coverage for this case?

incremental-font-transfer/src/patchmap.rs Outdated Show resolved Hide resolved
@garretrieger
Copy link
Contributor Author

looks good.

I'm curious if you're enforcing the invariant that start <= end, for your ranges? And/or have some test coverage for this case?

Yeah, here: https://github.com/googlefonts/fontations/blob/main/incremental-font-transfer/src/patchmap.rs#L437

Also internally RangeSet ignores attempts to add ranges with start > end so it's not possible to construct one that has bad ranges.

@garretrieger
Copy link
Contributor Author

looks good.
I'm curious if you're enforcing the invariant that start <= end, for your ranges? And/or have some test coverage for this case?

Yeah, here: https://github.com/googlefonts/fontations/blob/main/incremental-font-transfer/src/patchmap.rs#L437

Also internally RangeSet ignores attempts to add ranges with start > end so it's not possible to construct one that has bad ranges.

and tests here: https://github.com/googlefonts/fontations/blob/main/incremental-font-transfer/src/patchmap.rs#L1998

@garretrieger garretrieger merged commit 31fd33b into main Nov 29, 2024
10 checks passed
@garretrieger garretrieger deleted the design_space branch November 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants