[crater] Support for private fonts #1202
Conversation
That is, fonts that live in private repos under the googlefonts org.
|
|
||
| // skip Google Sans, which isn't built with gftools (but other fonts with | ||
| // names that begin with 'GoogleSans' might be!) | ||
| if ["GoogleSans", "GoogleSans-Italic"].contains(&file_stem.as_ref()) { |
There was a problem hiding this comment.
Let's file an issue to do this via a config marker rather than hard-coded list.
Why are we looking at the file stem, doesn't the config give us the family name?
There was a problem hiding this comment.
the family name isn't mandatory.
The config marker thing is a bit funny, in that the reason we're skipping gftools for these fonts is because they don't have gftools configs; the noto fonts have an extremely similar looking config file but don't build with gftools for legacy reasons, and GoogleSans has a stub I added manually.
basically: does it make sense to have a field in a gftools config file that says "don't build me with gftools"?
| LoadRepoError::Io(_) | ||
| | LoadRepoError::GitFail(_) | ||
| | LoadRepoError::NoCommit { .. } | ||
| | LoadRepoError::MissingAuth => SkipReason::GitFail, |
There was a problem hiding this comment.
If skip reasons surface in the UI or logs I suggest having one specifically for missing auth
There was a problem hiding this comment.
actually I think SkipReason is now completely unused, can delete in a followup.
That is, fonts that live in private repos under the googlefonts org.