Use fea-rs feature writer API for kerning #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This is a WIP; in particular I'm not sure how we should be passing errors around. That said this is working for features, and we can iterate from here.
rsheeter
force-pushed
the
feature-writer
branch
from
59497b4 to
6f75c18
Compare
|
Migrated to #517 which now has this and the fea-rs changes together. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP; in particular I'm not sure how we should be passing errors around. That said this is working for features, and we can iterate from here.
@rsheeter I think this should illustrate the overall approach? I'll also update the fea-rs PR (cmyr/fea-rs#241) to make the various mark builders public.