Remove unused quick-xml #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
println! checks are failing for unrelated reasons |
anthrotype
force-pushed
the
remove-quick-xml
branch
from
7d72482 to
8a75acb
Compare
|
looks good, though it might clash with #513, which just merged |
cmyr
approved these changes
Oct 26, 2023
it's a norad dependency but we don't import it directly anywhere in fontc so there's no need to have it here
anthrotype
force-pushed
the
remove-quick-xml
branch
from
8a75acb to
5eb5649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a norad dependency but we don't import it directly anywhere in fontc (
git grep quick_xmlreturns nothing) so there's no need to have it here, is there?