Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop infinite loop in .segments with quadratic curves #951

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Stop infinite loop in .segments with quadratic curves #951

merged 4 commits into from
Oct 25, 2023

Conversation

simoncozens
Copy link
Collaborator

Fixes #949.

@davelab6
Copy link
Member

This is urgent as it's blocking fonts onboarding targeted to q4 :)

anthrotype
anthrotype approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending linter fix

@simoncozens simoncozens merged commit cb8a4a9 into main Oct 25, 2023
9 checks passed
@khaledhosny khaledhosny deleted the fix-949 branch November 23, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop in .segments with quadratic curves
3 participants
@simoncozens @davelab6 @anthrotype