Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore #961

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Gitignore #961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb7ba8
on case-insensitive file systems this would ignore the main "Lib" fol…
schriftgestalt Nov 19, 2023
e7dbf02
Ignore autosave files from macOS
schriftgestalt Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ dist/
downloads/
eggs/
.eggs/
lib/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you actually had an issue with this lib/ directory being git-ignored on a case-insensitive filesystem?

I think it comes from this example .gitignore file for python projects from Github itself:
https://github.com/github/gitignore/blob/main/Python.gitignore#L17

/cc @madig who authored the original change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "lib" folder, only a "Lib" folder. And we like to keep that.
A new file inside that Lib folder will not show up in the git listing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok yes, I see now, thanks
let's merge

lib64/
parts/
sdist/
Expand Down Expand Up @@ -126,6 +125,9 @@ dmypy.json

# Autosaved files
*~
*(Autosaved).*
*(Automatisch gesichert).*
*(guardado automáticamente).*
simoncozens marked this conversation as resolved.
Show resolved Hide resolved

# setuptools_scm
_version.py
Expand Down