markFeatureWriter: Skip ignorable anchors #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glyphs allows anchors to start with non-letter characters and these are used internally to align components and should not be exported to the feature file. Fixes #963
anthrotype
approved these changes
Nov 22, 2023
|
@khaledhosny thanks. Could you by any chance try to see if this glyphsLib-specific markFeatureWriter will continue to work with the changes in googlefonts/ufo2ft#796 ? |
|
|
It is already handled and dropped from the name before the new check is called. |
Seems to work (as in no tests are failing, expect a minor change to |
khaledhosny
commented
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glyphs allows anchors to start with non-letter characters and these are used internally to align components and should not be exported to the feature file.
Fixes #963