Navigation compose #670
Navigation compose #670
Conversation
Adds support for the Navigation SDK to Maps Compose. It just allows the user to replace a standard MapView with a NavigationView within a GoogleMap composable. The following changes were made: Added a new NavigationViewDelegate class to handle the integration between NavigationView and Maps Compose. Added a new NavigationScreen composable function to display the navigation view. Added a new MovableMarker composable function to display a draggable marker on the map. Updated the GoogleMap composable function to support the use of NavigationView. Added a new NavigationApplication class to initialize the Places SDK. Added a new ApiKeyProvider class to provide API keys for the Maps and Places SDKs. Added a new LocationProvider class to provide location data. Added a new PermissionChecker class to check for location permissions. Updated the build.gradle.kts files to include the necessary dependencies. Updated the local.defaults.properties file to include the Places API key.
Adds NavigationViewDelegate to support NavigationView in the navigation sample app. This change allows the navigation sample app to use NavigationView, which provides turn-by-turn navigation functionality. The NavigationViewDelegate handles the lifecycle and rendering of the NavigationView, ensuring that it is properly integrated into the Jetpack Compose UI. Uses a MarkerComposable to demonstrate the map really is a composable
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| activitycompose = "1.9.3" | ||
| agp = "8.7.2" | ||
| androidxtest = "1.6.2" | ||
| agpVersion = "8.7.2" |
Check warning
Code scanning / Android Lint
Obsolete Android Gradle Plugin Version Warning
| activitycompose = "1.9.3" | ||
| agp = "8.7.2" | ||
| androidxtest = "1.6.2" | ||
| agpVersion = "8.7.2" |
Check warning
Code scanning / Android Lint
Obsolete Android Gradle Plugin Version Warning
| activitycompose = "1.9.3" | ||
| agp = "8.7.2" | ||
| androidxtest = "1.6.2" | ||
| agpVersion = "8.7.2" |
Check warning
Code scanning / Android Lint
Obsolete Android Gradle Plugin Version Warning
Code Coverage
|
| @@ -69,7 +69,7 @@ private fun MapView.ensureContainerView(): NoDrawContainerView { | |||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| @Composable | |||
| public fun rememberComposeUiViewRenderer(): ComposeUiViewRenderer { | |||
| val mapView = (currentComposer.applier as MapApplier).mapView | |||
| val mapView = (currentComposer.applier as MapApplier).mapViewDelegate | |||
There was a problem hiding this comment.
Wouldn't we need to pass the mapView here?
There was a problem hiding this comment.
The problem is that the first common ancestor of MapView and NavigationView is a View (technically, a ViewGroup). So there really isn't a shared "MapView" that we can use here (which is why I created the delegate).
|
|
||
| override fun onLowMemory() { | ||
| // TODO(): what is the correct value here? | ||
| mapView.onTrimMemory(ComponentCallbacks2.TRIM_MEMORY_COMPLETE) |
There was a problem hiding this comment.
There does not seem to be any reference to which value is the correct one, given that all of them are deprecated. The method does not really seem to be documented.
| @@ -145,19 +150,31 @@ public fun GoogleMap( | |||
| var subcompositionJob by remember { mutableStateOf<Job?>(null) } | |||
| val parentCompositionScope = rememberCoroutineScope() | |||
|
|
|||
| var delegate by remember { | |||
| // TODO: this could leak the view? | |||
There was a problem hiding this comment.
My two cents: if the AbstractMapViewDelegate is holding a reference to the Context it could leak. But I think we are directly not doing it, if we take a look at the mapViewDelegate, right? Not sure if using the java.lang.ref.WeakReference will make sense.
EDIT: Yeah, I think we are holding a reference in this file.
| override fun onStart(): Unit = mapView.onStart() | ||
| override fun onResume(): Unit = mapView.onResume() | ||
| override fun onPause(): Unit = mapView.onPause() | ||
| override fun onStop(): Unit = mapView.onStop() |
There was a problem hiding this comment.
We have a few other common methods, like some of the method listeners, saving/restoring instances, etc. Are they covered by the AbstractMapViewDelegate?
kikoso
force-pushed
the
navigation-compose
branch
from
d3c6162 to
934fee6
Compare
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕