Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transforms applying logic #4

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Fix transforms applying logic #4

merged 10 commits into from
Nov 30, 2023

Conversation

gorodnitskiy
Copy link
Owner

@gorodnitskiy gorodnitskiy commented Nov 30, 2023 •
edited
Loading

  • Remove logic of different stages from TransformsWrapper class. For now, this class requires transforms_cfg for some specific stage, e.g. train.
  • Update logic of applying of TransformsWrapper class in SingleDataModule (affecting to MultipleDataModule) and MNISTDataModule classes.
  • Add comment to mnist_datamodule.yaml about required augmentations for pipeline testing.
  • Specify python version for code quality workflows.
  • Bump versions for code quality workflows (checkout: 2 -> 4, setup-python: 2 -> 4, pre-commit: 2.0.3 -> 3.0.0).

@gorodnitskiy gorodnitskiy self-assigned this Nov 30, 2023
@gorodnitskiy gorodnitskiy changed the title Fix transforms applying during training Fix transforms applying logic Nov 30, 2023
@gorodnitskiy gorodnitskiy merged commit 299e780 into main Nov 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gorodnitskiy gorodnitskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gorodnitskiy