Adds IsLoading bindable property to pages and fixes SelectViewModelCommand #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maui has functionality tied to IsBusy now
Test Results 3 files 3 suites 3s ⏱️ Results for commit d2d4a6c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Maui, the
IsBusyproperty on pages now shows a loading indicator with no way to override that behavior. Since implementing apps may want their own loading indicator, this creates a newIsLoadingproperty which the implementing app can choose to forward toIsBusyif it wants.Also fixes the SelectViewModelCommand so it passes the model instead of the view model to the
CanExecutecallback.