Add alerts and fix thresholds #5
Conversation
| thresholds: | ||
| type: array | ||
| items: | ||
| type: object | ||
| properties: | ||
| colorMode: | ||
| title: Threshold Color | ||
| type: string | ||
| default: critical | ||
| fill: | ||
| title: Fill | ||
| type: boolean | ||
| default: true | ||
| line: | ||
| title: Line | ||
| type: boolean | ||
| default: true | ||
| op: | ||
| title: Operator | ||
| type: string | ||
| default: gt | ||
| value: | ||
| title: value | ||
| type: number |
There was a problem hiding this comment.
The filename update makes sense, but this new structure seems wrong. A thresholds object should look like this:
"thresholds": {
"mode": "absolute",
"steps": [
{
"color": "yellow",
"value": null
},
{
"color": "green",
"value": 0.7
},
{
"color": "red",
"value": 0.9
}
]
}
The deleted _threshold.yml file captures this schema.
There was a problem hiding this comment.
Sorry for the drive by comment, but I came across this PR whilst working on an experiment to port some of our Grafana JSON snapshots to Grafonnet 7.0. In one of our graphs we have a threshold like this:
{
"$": "object:458",
"colorMode": "critical",
"fill": true,
"line": true,
"op": "lt",
"value": 1,
"yaxis": "left"
}From looking at the graph with and without this threshold, it seems that in this form it will draw a line on the graph for the threshold. The current schema (the deleted _threshold.yml) does not allow for colorMode, fill, line, op, etc. to be specified, whereas the one in this PR does.
| alert: | ||
| $ref: "Alert.yml#/alert" |
There was a problem hiding this comment.
This should be removed. Alerts are part of graph panels.
| alert: | ||
| type: object | ||
| required: | ||
| - for | ||
| properties: | ||
| alertRuleTags: | ||
| type: object | ||
| conditions: | ||
| $ref: '#/conditions' | ||
| executionErrorState: | ||
| type: string | ||
| default: alerting | ||
| for: | ||
| type: string | ||
| default: 10m | ||
| frequency: | ||
| type: string | ||
| default: 1m | ||
| handler: | ||
| type: integer | ||
| message: | ||
| type: string | ||
| name: | ||
| type: string | ||
| noDataState: | ||
| type: string | ||
| default: no_data | ||
| notifications: | ||
| type: array | ||
| items: | ||
| properties: | ||
| uid: | ||
| type: string | ||
|
|
||
| conditions: | ||
| type: object | ||
| properties: | ||
| evaluator: | ||
| type: object | ||
| properties: | ||
| params: | ||
| type: array | ||
| items: | ||
| type: integer | ||
| type: | ||
| type: string | ||
| default: lt | ||
| operator: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| default: and | ||
| query: | ||
| type: object | ||
| properties: | ||
| params: | ||
| type: array | ||
| items: | ||
| type: string | ||
| reducer: | ||
| type: object | ||
| properties: | ||
| params: | ||
| type: array | ||
| type: | ||
| type: string | ||
| default: last | ||
| type: | ||
| type: string | ||
| default: query |
There was a problem hiding this comment.
This looks about right to me, but I don't think it should be a top-level schema component. Let's move this to specs/7.0/panels/_alert.yml. It should then be referenced in specs/7.0/panels/Graph.yml as currently only the graph panel supports alert rules.
|
|
Adds Grafana alerting support and renames threshold to thresholds