-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract user identity hook #344
Conversation
Add new test for testing EXTRACT_USER_IDENTITY
Create a release just once
This reverts commit 7f7fb0f.
Wow, this is great. Thanks for putting this together! Just tested it out and it appears to be working well for my use case. Just curious, is there a reason why the call to The current solution still works well, but I was wondering if there was a reason that more data wasn't passed to the create_user call to accomplish something similar. |
@jeremylivingston The idea is that the library should create a bare minimum user and then let the user (i.e. developer) set it up later. |
Makes sense. In my situation it can sometimes result in an orphaned user if there are problems with setup. The user will get created with no team assigned and the hook attempts to assign the team. If that step fails for some reason, it means the user is unable to login since they have no password and are not assigned to the correct team. It's not a huge deal since I can set up the necessary logging to notify us when it happens, but it would be cleaner if I could access the enriched data in the create_user step. Thanks again for all of your help with this! |
Thanks again for this! Any chance you'd be willing to tag a new version containing this update? |
Will do tomorrow. |
Closes #343.
CC: @jeremylivingston Please test this and see if this solution works for you. Feel free to review it as well and provide feedback.