chore: Display token information in partition ring status page #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
commented
Jan 2, 2025
| @@ -15,6 +15,8 @@ | |||
| <th>State</th> | |||
| <th>State updated at</th> | |||
| <th>Owners</th> | |||
| <th>Tokens</th> | |||
There was a problem hiding this comment.
Since we usually only show the Partition Ring page in ingest-storage mode, I chose not to add any extra toggle to show or hide these values. In contexts where these values don't make sense, the entire page is usually inaccessible.
| @@ -94,6 +94,34 @@ func (m *PartitionRingDesc) partitionByToken() map[Token]int32 { | |||
| return out | |||
| } | |||
|
|
|||
| // CountTokens returns the summed token distance of all tokens in each partition. | |||
| func (m *PartitionRingDesc) countTokens() map[int32]int64 { | |||
There was a problem hiding this comment.
Chose this name for consistency with its corresponding operation on the instance ring:
Line 625 in 9935aca
jhesketh
approved these changes
Jan 3, 2025
|
I noticed in the second screenshot the header was misleading, it reads Pushed a commit changing that. It's tiny, so i don't think that warrants resetting reviews. I'll leave this open for a bit longer in case of any objections, then merge. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The partition ring has a concept of tokens, but its tokens aren't visible in the partition ring status UI.
This PR ports the token-related affordances (count, ownership%, view all) from the ingester ring status page to the partition ring status page.
Screenshot of new columns:
When "Show Tokens" at the bottom is clicked:
Which issue(s) this PR fixes:
Contrib https://github.com/grafana/mimir-squad/issues/2350
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]