Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release prep #283

Merged
merged 5 commits into from
Jan 5, 2024
Merged

release prep #283

merged 5 commits into from
Jan 5, 2024

Conversation

yesoreyeram
Copy link
Contributor

@yesoreyeram yesoreyeram commented Jan 4, 2024 •
edited
Loading

  • Release prep
  • Made the tooltips interactive ( replaced local version of InlineField with the one from @grafana/ui package )

Before

image

After

  • replaced the blue labels with standard labels
  • tooltips are interactive ( contents can be clicked, copied )
image

@yesoreyeram yesoreyeram requested a review from a team as a code owner January 4, 2024 13:34
@yesoreyeram yesoreyeram requested review from gabor and zoltanbedi and removed request for a team January 4, 2024 13:34
zoltanbedi
zoltanbedi approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing but other than that all good.

src/views/QueryEditorPullRequests.tsx Outdated Show resolved Hide resolved
@yesoreyeram yesoreyeram merged commit 124fcb6 into main Jan 5, 2024
3 checks passed
@yesoreyeram yesoreyeram deleted the sriram/release-20240104 branch January 5, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@gabor gabor Awaiting requested review from gabor gabor is a code owner automatically assigned from grafana/oss-big-tent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesoreyeram @zoltanbedi