Add support for workflow runs data #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lehmanju
force-pushed
the
get-workflow-runs
branch
from
fa1e825 to
757b133
Compare
|
Here's a screenshot of how it looks like. Branch can be left empty, workflow works with id and file name. |
|
After this has been merged, I would appreciate a new release. |
lehmanju
force-pushed
the
get-workflow-runs
branch
from
28a1ea9 to
e6052e8
Compare
lehmanju
force-pushed
the
get-workflow-runs
branch
from
e6052e8 to
24ae398
Compare
|
@ivanahuckova Sry to bump but it's been a month and I'd greatly appreciate a review. |
lehmanju
force-pushed
the
get-workflow-runs
branch
from
24ae398 to
4f51a5a
Compare
lehmanju
force-pushed
the
get-workflow-runs
branch
from
4f51a5a to
b150ab9
Compare
gwdawson
reviewed
Feb 4, 2025
|
|
||
| workflowRuns, err := client.GetWorkflowRuns(ctx, opts.Owner, opts.Repository, opts.Workflow, opts.Branch, timeRange) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("listing workflows: opts=%+v %w", opts, err) |
There was a problem hiding this comment.
i think returning just err here is sufficient.
currently, the error message is: listing workflows: opts={Owner:grafana Repository:grafana Workflow: Branch:} fetching workflow runs: <github error>
If we return only err, it becomes: fetching workflow runs: <github_error> which i believe is much clearer.
gwdawson
reviewed
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395 and provides an option to filter based on a branch.
Has been tested with github.com but should work with enterprise as well since most of the code is boilerplate/adjusted from WorkflowUsage API.