Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datasource configuration page #214

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Update datasource configuration page #214

merged 3 commits into from
Oct 25, 2023

Conversation

gwdawson
Copy link
Member

updates the bigquery config page to align with the config page best practices

Before & After:

Screenshot 2023-10-17 at 11 52 56 Screenshot 2023-10-17 at 11 53 08

@gwdawson gwdawson self-assigned this Oct 17, 2023
@gwdawson gwdawson requested a review from a team as a code owner October 17, 2023 10:57
@gwdawson gwdawson requested review from gabor and zoltanbedi and removed request for a team October 17, 2023 10:57
@gwdawson gwdawson mentioned this pull request Oct 18, 2023
Closed
16 tasks
zoltanbedi
zoltanbedi approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gwdawson gwdawson merged commit d67e1b4 into main Oct 25, 2023
1 check passed
@gwdawson gwdawson deleted the gareth/config-page branch October 25, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@gabor gabor Awaiting requested review from gabor gabor is a code owner automatically assigned from grafana/oss-big-tent

Assignees

@gwdawson gwdawson

Labels
None yet
Projects
OSS Big Tent
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwdawson @zoltanbedi