fix: no need to send span when window is not null, change key for error

grafana · Dec 4, 2024 · 71db1bc · 71db1bc
1 parent 3deda55
commit 71db1bc
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/custom/src/main/java/com/grafana/extensions/sampler/DynamicSampler.java b/custom/src/main/java/com/grafana/extensions/sampler/DynamicSampler.java
@@ -19,7 +19,7 @@
 import java.util.logging.Logger;
 
 public class DynamicSampler {
-  private static final AttributeKey<String> EXCEPTION = AttributeKey.stringKey("exception.type");
+  private static final AttributeKey<String> EXCEPTION = AttributeKey.stringKey("error.type");
   private final Set<String> sampledTraces = new ConcurrentSkipListSet<>();
   public static final Logger logger = Logger.getLogger(DynamicSampler.class.getName());
   private final int windowSize;
@@ -95,7 +95,9 @@ private boolean isSlow(ReadableSpan span) {
     MovingAverage currMovingAvg =
         movingAvgs.computeIfAbsent(spanName, ma -> new MovingAverage(windowSize));
     currMovingAvg.add(duration);
-    if (currMovingAvg.getCount() >= windowSize) {
+    if (currMovingAvg.getCount() < windowSize) {
+      return false;
+    }
       double avg = currMovingAvg.calcAverage();
       logger.log(
           Level.INFO,
@@ -105,7 +107,6 @@ private boolean isSlow(ReadableSpan span) {
       if (duration < avg * threshold) {
         return false;
       }
-    }
     logger.log(
         Level.INFO,
         "sending span part of Trace: {0} - {1}",