exclude propagation for now so we can test the algo

grafana · Dec 4, 2024 · 903dbab · 903dbab
1 parent c5fbef3
commit 903dbab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/custom/src/main/java/com/grafana/extensions/sampler/DeferredSampler.java b/custom/src/main/java/com/grafana/extensions/sampler/DeferredSampler.java
@@ -41,10 +41,13 @@ public SamplingResult shouldSample(
             .shouldSample(parentContext, traceId, name, spanKind, attributes, parentLinks)
             .getDecision();
     if (SamplingDecision.RECORD_AND_SAMPLE.equals(parentDecision)) {
-      DynamicSampler.setSampled(traceId);
+      // todo: fix propagation
+//      DynamicSampler.setSampled(traceId);
     }
 
     // always return true - because a child span might be sampled even if the parent is not
+    // todo: fix propagation
+//    return SamplingResult.recordOnly();
     return SamplingResult.recordAndSample();
   }
 }
diff --git a/custom/src/main/java/com/grafana/extensions/servertiming/ServerTimingHeaderCustomizer.java b/custom/src/main/java/com/grafana/extensions/servertiming/ServerTimingHeaderCustomizer.java
@@ -40,7 +40,9 @@ public <RESPONSE> void customize(
   static String toHeaderValue(Context context) {
     ReadWriteSpan span = (ReadWriteSpan) Span.fromContext(context);
     SpanContext spanContext = span.getSpanContext();
-    boolean sampled = DynamicSampler.evaluateSampled(span);
+//    boolean sampled = DynamicSampler.evaluateSampled(span);
+    // todo: fix propagation
+    boolean sampled = false;
     TraceParentHolder traceParentHolder = new TraceParentHolder();
     W3CTraceContextPropagator.getInstance()
         .inject(