Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't send span when windows is not full #835

Closed
wants to merge 1 commit into from

Conversation

s4kh
Copy link

@s4kh s4kh commented Dec 4, 2024

Fixes #

Changes

Don't send span when window is not full

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md file updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@s4kh s4kh requested a review from zeitlinger as a code owner December 4, 2024 15:13
@s4kh s4kh force-pushed the fix-window-not-full branch from 7de159d to 7f10ba8 Compare December 4, 2024 15:14
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Syerikjan Khusayan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@s4kh s4kh self-assigned this Dec 4, 2024
@s4kh s4kh closed this Dec 4, 2024
@s4kh
Copy link
Author

s4kh commented Dec 4, 2024

included in #834

@zeitlinger zeitlinger deleted the fix-window-not-full branch December 6, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants