[grafana] Range over extraVolumes #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efbicief
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
zanhsieh
changed the title
Previously, this was ranging over extraVolumeClaims instead of extraVolumes, which meant extraVolumes was never read. This also correctly inserts all data from hostPath volumes, and aallows configMaps to be used as an extraVolume. Signed-off-by: Felix B <[email protected]>
Signed-Off-By: Felix B <[email protected]> Signed-off-by: Felix B <[email protected]>
Signed-off-by: Felix B <[email protected]>
|
Apologies for the delay, hopefully that is okay now. |
|
I see we are now on 6.61.1 - should version be bumped to 6.61.2? |
Signed-off-by: MH <[email protected]>
zanhsieh
approved these changes
Oct 29, 2023
szinn
referenced
this pull request
in szinn/k8s-homelab
Oct 30, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [grafana](https://grafana.net) ([source](https://togithub.com/grafana/helm-charts)) | major | `6.61.1` -> `7.0.1` | --- ### Release Notes <details> <summary>grafana/helm-charts (grafana)</summary> ### [`v7.0.1`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-7.0.1) [Compare Source](https://togithub.com/grafana/helm-charts/compare/grafana-7.0.0...grafana-7.0.1) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: include podAnnotation in grafana values for imagerenderer by [@​KelvinVenancio](https://togithub.com/KelvinVenancio) in [https://github.com/grafana/helm-charts/pull/2738](https://togithub.com/grafana/helm-charts/pull/2738) #### New Contributors - [@​KelvinVenancio](https://togithub.com/KelvinVenancio) made their first contribution in [https://github.com/grafana/helm-charts/pull/2738](https://togithub.com/grafana/helm-charts/pull/2738) **Full Changelog**: grafana/helm-charts@grafana-7.0.0...grafana-7.0.1 ### [`v7.0.0`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-7.0.0) [Compare Source](https://togithub.com/grafana/helm-charts/compare/grafana-6.61.2...grafana-7.0.0) The leading tool for querying and visualizing time series and metrics. #### What's Changed - Update CODEOWNERS by [@​zalegrala](https://togithub.com/zalegrala) in [https://github.com/grafana/helm-charts/pull/2744](https://togithub.com/grafana/helm-charts/pull/2744) - \[grafana] Rename global.image.registry to global.imageRegistry by [@​pvallone](https://togithub.com/pvallone) in [https://github.com/grafana/helm-charts/pull/2735](https://togithub.com/grafana/helm-charts/pull/2735) #### New Contributors - [@​pvallone](https://togithub.com/pvallone) made their first contribution in [https://github.com/grafana/helm-charts/pull/2735](https://togithub.com/grafana/helm-charts/pull/2735) **Full Changelog**: grafana/helm-charts@grafana-6.61.2...grafana-7.0.0 ### [`v6.61.2`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-6.61.2) [Compare Source](https://togithub.com/grafana/helm-charts/compare/grafana-6.61.1...grafana-6.61.2) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Range over extraVolumes by [@​efbicief](https://togithub.com/efbicief) in [https://github.com/grafana/helm-charts/pull/2712](https://togithub.com/grafana/helm-charts/pull/2712) #### New Contributors - [@​efbicief](https://togithub.com/efbicief) made their first contribution in [https://github.com/grafana/helm-charts/pull/2712](https://togithub.com/grafana/helm-charts/pull/2712) **Full Changelog**: grafana/helm-charts@loki-distributed-0.76.1...grafana-6.61.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMzUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
diversit
added a commit
to diversit/helm-charts
that referenced
this pull request
Nov 15, 2023
Fixing issue grafana#2777 by adding back mounting any volumes in the 'extraVolumeMounts' property which was removed by PR grafana#2712 .
diversit
added a commit
to diversit/helm-charts
that referenced
this pull request
Nov 15, 2023
Fixing issue grafana#2777 by adding back mounting any volumes in the 'extraVolumeMounts' property which was removed by PR grafana#2712 . Signed-off-by: Joost den Boer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was ranging over extraVolumeClaims instead of extraVolumes, which meant extraVolumes was never read. This caused volumes mounted as extraVolumes to be mounted as emptyDirs.
This also correctly inserts all data from hostPath volumes, and allows configMaps to be used as an extraVolume.
This should fix prometheus-community/helm-charts#3851