-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loki-distributed] Add Query Frontend to the memberlist and allow matchExpression
on ServiceMonitor
#2732
Merged
MichelHollands
merged 13 commits into
grafana:main
from
verejoel:feature/ingester-deployment
Nov 29, 2023
Merged
[loki-distributed] Add Query Frontend to the memberlist and allow matchExpression
on ServiceMonitor
#2732
MichelHollands
merged 13 commits into
grafana:main
from
verejoel:feature/ingester-deployment
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: verejoel <[email protected]>
Signed-off-by: verejoel <[email protected]>
Signed-off-by: verejoel <[email protected]>
Signed-off-by: verejoel <[email protected]>
Signed-off-by: verejoel <[email protected]>
matchExpression
on ServiceMonitor
Signed-off-by: verejoel <[email protected]>
a829f69
to
425a9d1
Compare
zanhsieh
approved these changes
Nov 7, 2023
@zanhsieh thanks for the review - can this be merged? |
@zalegrala would you also be able to review here please? |
@grafana/loki-squad @unguiculus @Whyeasy need your review here. @zalegrala please extend code owners list for this chart. Currently here is just 1 active maintainer. |
MichelHollands
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Query Frontend joins the Memberlist
When using the query scheduler ring, the query frontend must join the memberlist. This is because the query frontend needs to know which members of the scheduler ring are healthy, and the scheduler will only send heartbeats on port 7946.
In the existing configuration, when the scheduler ring is enabled, the query frontend sees the schedulers get unhealthy periodically. Also, the regular heartbeat is not received every 15 seconds. This is because the query schedulers cannot write to port 7946 on the frontend:
Furthermore, the query schedulers mark the query frontends as unhealthy, as they receive no
acks
on the memberlist:This PR introduces the required container port
7946
and memberlist selector label on the query frontend component. This configuration has been tested in a production environment, and confirmed to fix communication issues between the frontend, querier, and scheduler components.ServiceMonitor
matchExpression
Some ServiceMonitors had the following
matchExpression
stanza hardcoded:This has now been made a configurable value, which is empty by default. This ensures the ServiceMonitor configuration is predictable across all components.
Minor changes
The ingester deployment was missing some features of the StatefulSet. These have been copied across.