Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: simplify helm workflows #444

Merged
merged 1 commit into from
Aug 21, 2024
Merged

CI: simplify helm workflows #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/helm-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,4 @@ jobs:

- name: Run chart-testing (lint)
run: |
# is there a better way to get the right name for branch?
# for ref.: https://github.com/helm/chart-testing/issues/186#issuecomment-585595379
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
ct lint --target-branch ${{ github.head_ref }} --config ./charts/ct.yaml
else
ct lint --target-branch ${{ github.ref_name }} --config ./charts/ct.yaml
fi
ct lint --config ./charts/ct.yaml
12 changes: 2 additions & 10 deletions .github/workflows/helm-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,7 @@ jobs:
- name: Run chart-testing (list-changed)
id: list-changed
run: |
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
changed=$(ct list-changed --config ./charts/ct.yaml --target-branch ${{ github.head_ref }})
else
changed=$(ct list-changed --config ./charts/ct.yaml --target-branch ${{ github.ref_name }})
fi
changed=$(ct list-changed --config ./charts/ct.yaml)

if [[ -n "$changed" ]]; then
echo "changed=true" >> $GITHUB_OUTPUT
Expand All @@ -52,8 +48,4 @@ jobs:
- name: Run chart-testing (install)
if: steps.list-changed.outputs.changed == 'true'
run: |
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
ct install --target-branch ${{ github.head_ref }} --charts ./charts/
else
ct install --target-branch ${{ github.ref_name }} --charts ./charts/
fi
ct install --charts ./charts/
Loading