Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pod storage metrics #1047

Merged
merged 3 commits into from
Jan 2, 2025
Merged

feat: add pod storage metrics #1047

merged 3 commits into from
Jan 2, 2025

Conversation

skl
Copy link
Member

@skl skl commented Jan 2, 2025

This PR adds metrics to the default allow lists for Kubelet and KSM required for pod storage observability. Also make the v1/v2 lists consistent with each other.

@skl skl added the enhancement New feature or request label Jan 2, 2025
@skl skl self-assigned this Jan 2, 2025
@skl skl requested a review from a team as a code owner January 2, 2025 18:50
@petewall petewall merged commit bd4fba6 into main Jan 2, 2025
31 of 32 checks passed
@petewall petewall deleted the skl/add-pod-storage-metrics branch January 2, 2025 20:21
bentonam pushed a commit that referenced this pull request Jan 6, 2025
* feat: add pod storage metrics

* build: make clean build

* fix: tests
bentonam added a commit that referenced this pull request Jan 6, 2025
* Added Grafana Integration

* Updated Common Relabelings

* Updated Loki Integration and Added Tests

* Updated Build Dependencies

* Updated deprecated stdlib env() w/ sys.env (#1027)

* Fixed deprecated stdlib env() with sys.env()

Resolves #1026

* Updated Build Dependencies and Artifacts

* Rebuilt

* Fix the check if the filters are enabled

Signed-off-by: Pete Wall <[email protected]>

* Fix the type of endpoint params (#1029)

Signed-off-by: Pete Wall <[email protected]>

* Bump version to 2.0.0-rc.11
Also fix k8s-monitoring-test branch

Signed-off-by: Pete Wall <[email protected]>

* fix input for filter and memory limiter processors (#1037)

Signed-off-by: Pete Wall <[email protected]>

* Bump version to 2.0.0-rc.12

Signed-off-by: Pete Wall <[email protected]>

* chore(dev-deps): bump markdownlint-cli2 from 0.16.0 to 0.17.0 (#1041)

Bumps [markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2) from 0.16.0 to 0.17.0.
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md)
- [Commits](DavidAnson/markdownlint-cli2@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: markdownlint-cli2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update KSM, Node Exporter, and OpenCost (#1045)

* Update KSM, Node Exporter, and OpenCost

Signed-off-by: Pete Wall <[email protected]>

* fix deterministic ordering of the mysql integration

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* feat: add pod storage metrics (#1047)

* feat: add pod storage metrics

* build: make clean build

* fix: tests

* Update example docs (#1023)

* Update example docs

Signed-off-by: Pete Wall <[email protected]>

* Update charts/k8s-monitoring/docs/examples/platforms/openshift/README.md

Co-authored-by: Beverly Buchanan <[email protected]>

* Fix examples

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Beverly Buchanan <[email protected]>

* Move the feature charts as directories inside of the k8s-monitoring chart (#1046)

* Move the feature charts as directories inside of the k8s-monitoring chart.

Signed-off-by: Pete Wall <[email protected]>

* Fix changed files and tests

* remove extra subcharts that were added during a rebase

Signed-off-by: Pete Wall <[email protected]>

* Use local helm-schema-gen if it's available

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Fix pod annotation duplication (#1050)

* Add DPM checks for control plane integration test and add a test for annotation autodiscovery

Signed-off-by: Pete Wall <[email protected]>

* Drop the __tmp_port label, which breaks autodiscovery deduplication

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Bump versions to 1.6.17 and 2.0.0-rc.13

Signed-off-by: Pete Wall <[email protected]>

* chore(dev-deps): bump textlint from 14.4.0 to 14.4.2 (#1051)

Bumps [textlint](https://github.com/textlint/textlint) from 14.4.0 to 14.4.2.
- [Release notes](https://github.com/textlint/textlint/releases)
- [Commits](textlint/textlint@v14.4.0...v14.4.2)

---
updated-dependencies:
- dependency-name: textlint
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(dev-deps): bump markdownlint-cli2 from 0.17.0 to 0.17.1 (#1052)

Bumps [markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2) from 0.17.0 to 0.17.1.
- [Changelog](https://github.com/DavidAnson/markdownlint-cli2/blob/main/CHANGELOG.md)
- [Commits](DavidAnson/markdownlint-cli2@v0.17.0...v0.17.1)

---
updated-dependencies:
- dependency-name: markdownlint-cli2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated Loki Integration and Added Tests

* Updated Build Dependencies

* Added Grafana Integration

* Updated Meta-Monitoring

* Updated Loki Tests

* Updated ls command to use no color

* Rebuilt

* Sort the valueList

* Updated Tests

* Fixed typo and Rebuilt

* Changed ls command to never use color

* Regenerated Output

* Updated vendir alloyModules

* Updated stdlib join to be string.join

* Rebuilt

* Rebuilt

* Removed Unused Default Allow List

---------

Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stephen Lang <[email protected]>
Co-authored-by: Beverly Buchanan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants