Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use certFile and keyFile settings #1143

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

petewall
Copy link
Collaborator

@petewall petewall commented Jan 18, 2025

Just like caFile, if these are provided, it'll use them instead of trying to find them in the secret.

@petewall petewall self-assigned this Jan 18, 2025
@petewall petewall linked an issue Jan 18, 2025 that may be closed by this pull request
@petewall petewall merged commit 5eb8e76 into main Jan 18, 2025
32 checks passed
@petewall petewall deleted the fix/certfile-and-keyfile branch January 18, 2025 03:32
bentonam pushed a commit that referenced this pull request Jan 21, 2025
bentonam added a commit that referenced this pull request Jan 22, 2025
* Added Mimir Integration

* updated meta-monitoring example

* Update charts/k8s-monitoring/charts/feature-integrations/integrations/mimir-values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Update charts/k8s-monitoring/charts/feature-integrations/integrations/mimir-values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Updated docs

* Doc improvements to link to other charts and reference resource requests and limits (#1131)

* Doc improvements to link to other charts and reference resource requests and limits

Signed-off-by: Pete Wall <[email protected]>

* Fix yaml lint issues

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Update Update dependency "beyla" for Helm chart "feature-auto-instrumentation" to 1.6.3 (#1134)

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: petewall <[email protected]>

* Update Update dependency "beyla" for Helm chart "k8s-monitoring-v1" to 1.6.3 (#1135)

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: petewall <[email protected]>

* Add permissions for the internal directory

Signed-off-by: Pete Wall <[email protected]>

* Actually use certFile and keyFile settings (#1143)

Signed-off-by: Pete Wall <[email protected]>

* Bump versions to 1.6.21 and 2.0.4

Signed-off-by: Pete Wall <[email protected]>

* Rebuilt

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: petewall <[email protected]>
petewall added a commit that referenced this pull request Jan 22, 2025
petewall added a commit that referenced this pull request Jan 22, 2025
* Added Mimir Integration

* updated meta-monitoring example

* Update charts/k8s-monitoring/charts/feature-integrations/integrations/mimir-values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Update charts/k8s-monitoring/charts/feature-integrations/integrations/mimir-values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Updated docs

* Doc improvements to link to other charts and reference resource requests and limits (#1131)

* Doc improvements to link to other charts and reference resource requests and limits

Signed-off-by: Pete Wall <[email protected]>

* Fix yaml lint issues

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Update Update dependency "beyla" for Helm chart "feature-auto-instrumentation" to 1.6.3 (#1134)

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: petewall <[email protected]>

* Update Update dependency "beyla" for Helm chart "k8s-monitoring-v1" to 1.6.3 (#1135)

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: petewall <[email protected]>

* Add permissions for the internal directory

Signed-off-by: Pete Wall <[email protected]>

* Actually use certFile and keyFile settings (#1143)

Signed-off-by: Pete Wall <[email protected]>

* Bump versions to 1.6.21 and 2.0.4

Signed-off-by: Pete Wall <[email protected]>

* Rebuilt

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: petewall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certFile and keyFile not used in prometheus destination
1 participant