chore: Update ASCII diagram of chunk binary encoding #15386
Merged
+105
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking we should update https://grafana.com/docs/loki/latest/operations/storage/#chunk-format too. |
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/update-chunkenc-ascii-diagram
branch
from
c17a86a to
92edc35
Compare
github-actions
bot
added
the
type/docs
|
@chaudum , which branches should we backport this to? Or should it just be in "next" for the next release? |
JoaoBraveCoding
approved these changes
Dec 17, 2024
It's sufficient to keep this on main and release it with the next version |
|
💻 Deploy preview deleted. |
mveitas
pushed a commit
to mveitas/loki
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The new diagram reflects the new v4 chunk version.
The old diagram was missing the structured metadata section (interned strings).