Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed indentation for sandbox tags #15678

Merged
merged 1 commit into from
Jan 10, 2025
Merged

docs: fixed indentation for sandbox tags #15678

merged 1 commit into from
Jan 10, 2025

Conversation

Jayclifford345
Copy link
Contributor

What this PR does / why we need it:
Just fixing the indentation for sandbox meta tags so it parses correctly.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner January 10, 2025 10:51
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

💻 Deploy preview available: https://deploy-preview-loki-15678-zb444pucvq-vp.a.run.app/docs/loki/latest/

JStickler
JStickler approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler merged commit c7d578e into main Jan 10, 2025
64 checks passed
@JStickler JStickler deleted the hotfix-quick-start branch January 10, 2025 20:06
loki-gh-app bot pushed a commit that referenced this pull request Jan 10, 2025
@Jayclifford345 @grafana-delivery-bot
docs: fixed indentation for sandbox tags (#15678)
01a0052 
(cherry picked from commit c7d578e)
loki-gh-app bot pushed a commit that referenced this pull request Jan 10, 2025
@Jayclifford345 @grafana-delivery-bot
docs: fixed indentation for sandbox tags (#15678)
7d380ab 
(cherry picked from commit c7d578e)
This was referenced Jan 10, 2025
Merged
Merged
loki-gh-app bot pushed a commit that referenced this pull request Jan 10, 2025
@Jayclifford345 @grafana-delivery-bot
docs: fixed indentation for sandbox tags (#15678)
7c40a54 
(cherry picked from commit c7d578e)
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 10, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayclifford345 @JStickler