Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link to the docker plugin configuration page #15701

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

myrkytyn
Copy link
Contributor

What this PR does / why we need it:
This PR fixes the broken link to the Docker plugin configuration documentation in the Grafana Loki guides. The link was previously pointing to a non-existent page, and has been updated to direct users to the correct Docker driver configuration documentation.
image

Which issue(s) this PR fixes:
Fixes the broken link to the docker plugin configuration page

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Fixed the broken link to the docker plugin configuration page

Signed-off-by: Maksym Mykytyn <[email protected]>
@myrkytyn myrkytyn requested a review from a team as a code owner January 11, 2025 12:00
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 11, 2025
@gediminasz
Copy link

Can I also suggest changing this link to this page: https://grafana.com/docs/loki/latest/send-data/docker-driver/configuration/

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] @myrkytyn thanks for taking the time to update the docs, and @gediminasz thanks for catching that the link was to the wrong configuration page.

@JStickler JStickler merged commit a6d8891 into grafana:main Jan 13, 2025
60 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
Signed-off-by: Maksym Mykytyn <[email protected]>
Signed-off-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit a6d8891)
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
Signed-off-by: Maksym Mykytyn <[email protected]>
Signed-off-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit a6d8891)
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
Signed-off-by: Maksym Mykytyn <[email protected]>
Signed-off-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit a6d8891)
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
Signed-off-by: Maksym Mykytyn <[email protected]>
Signed-off-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit a6d8891)
@myrkytyn myrkytyn deleted the patch-1 branch January 13, 2025 22:07
@myrkytyn
Copy link
Contributor Author

@JStickler thank you for your review and merge!
I found two more files where the ">" is also missing.
I’ve opened a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants