-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken link to the docker plugin configuration page #15701
Conversation
Fixed the broken link to the docker plugin configuration page Signed-off-by: Maksym Mykytyn <[email protected]>
Can I also suggest changing this link to this page: https://grafana.com/docs/loki/latest/send-data/docker-driver/configuration/ |
Signed-off-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] @myrkytyn thanks for taking the time to update the docs, and @gediminasz thanks for catching that the link was to the wrong configuration page.
Signed-off-by: Maksym Mykytyn <[email protected]> Signed-off-by: J Stickler <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit a6d8891)
Signed-off-by: Maksym Mykytyn <[email protected]> Signed-off-by: J Stickler <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit a6d8891)
Signed-off-by: Maksym Mykytyn <[email protected]> Signed-off-by: J Stickler <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit a6d8891)
Signed-off-by: Maksym Mykytyn <[email protected]> Signed-off-by: J Stickler <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit a6d8891)
@JStickler thank you for your review and merge! |
What this PR does / why we need it:
This PR fixes the broken link to the Docker plugin configuration documentation in the Grafana Loki guides. The link was previously pointing to a non-existent page, and has been updated to direct users to the correct Docker driver configuration documentation.
Which issue(s) this PR fixes:
Fixes the broken link to the docker plugin configuration page
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR