-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix missing deploymentMode: SingleBinary #15744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This missing line causes the StatefulSet/loki to be missing Signed-off-by: Rafael Passos <[email protected]>
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Jan 14, 2025
JStickler
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM, thanks for taking the time to update the docs.
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Rafael Passos <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 26fa93c)
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Rafael Passos <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 26fa93c)
6 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Rafael Passos <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 26fa93c)
This was referenced Jan 14, 2025
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Rafael Passos <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 26fa93c)
6 tasks
Thanks! This was the fastest merge I've ever seen 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release-3.0.x
backport release-3.1.x
backport release-3.2.x
backport release-3.3.x
size/XS
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This missing line causes the StatefulSet/loki to be missing.
If one would copy the "s3" or "azure" sections of this guide, it is possible to miss the "deploymentMode" config (I did it).
It was awful to figure out the mistake, because first timers will not notice the missing StatefullSet (since there is aready a deamonset).
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR