Add MaxSurge and MaxUnavailable strategy to all Loki k8 workloads.
#5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes couple of issues. 1. By default these configs are 25% in k8, meaning during rollout 25% of pods are allowed to shutdown immediately. 2. Due to (1), during graceful shutdown process, 25% of all the pods access consul to `unregister()` from shared key value. (2) makes CAS rate of underlying KV store high (leads to lots of retry and failing) sometimes failing to unregister leaving the ring "unhealthy" Also this PR make these configs consistent across all k8 workloads. More details: grafana/dskit#117
DylanGuedes
approved these changes
Jan 24, 2022
Comment on lines
74
to
75
| statefulSet.mixin.spec.strategy.rollingUpdate.withMaxSurge(0) + | ||
| statefulSet.mixin.spec.strategy.rollingUpdate.withMaxUnavailable(1) |
There was a problem hiding this comment.
maxSurge and maxUnavailable are not supported by statefulset. There is an open proposal to add support for maxUnavailable to statefulsets and maxSurge would not work with statefulset as per comment which makes sense.
There was a problem hiding this comment.
good catch @sandeepsukhani . Fixed 👍
Signed-off-by: Kaviraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes two changes.
MaxSurge:5andMaxUnavailable:1for all the stateless workloadsMaxSurge:0andMaxUnavailable:1for all the stateful workloadsThis fixes couple of issues.
unregister()from shared key value.(2) makes CAS rate of underlying KV store high (leads to lots of retry and failing) sometimes failing to unregister leaving the ring "unhealthy"
Also this PR make these configs consistent across all k8 workloads.
More details: grafana/dskit#117
Which issue(s) this PR fixes:
Fixes #5191
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.