Skip to content

Commit

Permalink
refactor(mimirpb): delete TestRemoteWriteV1HistogramEquivalence
Browse files Browse the repository at this point in the history
As far as I can tell we don't cast Prometheus Remote Write 1.0
histogram into mimirpb.Histogram anymore. On the flip-side
this test fails in #10432 because we're going to store RW 2.0
extra field in mimirpb.Histogram.

Related to #9072

Signed-off-by: György Krajcsovits <[email protected]>
  • Loading branch information
krajorama committed Jan 16, 2025
1 parent 377e37e commit a864aa3
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/mimirpb/compat_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -739,10 +739,6 @@ func TestCompareLabelAdapters(t *testing.T) {
}
}

func TestRemoteWriteV1HistogramEquivalence(t *testing.T) {
test.RequireSameShape(t, prompb.Histogram{}, Histogram{}, false, true)
}

// The main usecase for `LabelsToKeyString` is to generate hashKeys
// for maps. We are benchmarking that here.
func BenchmarkSeriesMap(b *testing.B) {
Expand Down

0 comments on commit a864aa3

Please sign in to comment.